-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves #10681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` [ RUN ] EnergyPlusFixture.GAHP_AirSource_CurveEval /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5650: Failure Expected equality of these values: oaTemp Which is: 3 oaTempforCurve Which is: 43.0859 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5658: Failure Expected equality of these values: oaTemp Which is: 3 oaTempforCurve Which is: 43.0859 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5664: Failure Expected equality of these values: oaTemp Which is: 3 oaTempforCurve Which is: 3.33333 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5693: Failure Expected equality of these values: oaTemp Which is: 3 oaTempforCurve Which is: 43.0859 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5701: Failure Expected equality of these values: oaTemp Which is: 3 oaTempforCurve Which is: 43.0859 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5736: Failure Expected equality of these values: oaWetbulb Which is: -4.36026 oaTempforCurve Which is: 15.7288 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5744: Failure Expected equality of these values: oaWetbulb Which is: -4.36026 oaTempforCurve Which is: 15.7288 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5750: Failure Expected equality of these values: oaWetbulb Which is: -4.36026 oaTempforCurve Which is: 3.33333 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5778: Failure Expected equality of these values: oaWetbulb Which is: -4.36026 oaTempforCurve Which is: 17.0828 /home/julien/Software/Others/EnergyPlus2/tst/EnergyPlus/unit/PlantLoopHeatPumpEIR.unit.cc:5786: Failure Expected equality of these values: oaWetbulb Which is: -4.36026 oaTempforCurve Which is: 17.0828 [ FAILED ] EnergyPlusFixture.GAHP_AirSource_CurveEval (900 ms) ```
…ide air temperatures to evaluate curves
jmarrec
changed the title
Fix #10387 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves
Fix #10665 - HeatPump:AirToWater:FuelFired:Heating was not using Outside air temperatures to evaluate curves
Aug 21, 2024
jmarrec
added
the
NotIDDChange
Code does not impact IDD (can be merged after IO freeze)
label
Aug 21, 2024
Redone in #10682, apologies |
jmarrec
removed
Defect
Includes code to repair a defect in EnergyPlus
NotIDDChange
Code does not impact IDD (can be merged after IO freeze)
labels
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
HeatPump:AirToWater:FuelFired:Heating
curves not using two independent temperature variables #10665Using PlantLoopHeatPump_Fuel-Fired.idf , before versus after, plotting the
CAPCURVEFUNCTEMP2
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.